Still LGTM.
http://codereview.chromium.org/316010/diff/9002/6004 File src/x64/disasm-x64.cc (right): http://codereview.chromium.org/316010/diff/9002/6004#newcode661 Line 661: assert(*data == 0xF7 || *data == 0xF6); Shouldn't this be ASSERT? (I.e., using our own ASSERT, not the C++ assert.h library). http://codereview.chromium.org/316010/diff/9002/6004#newcode811 Line 811: ASSERT((escape_opcode & 0xF8) == 0xD8); Use ASSERT_EQ (or switch to assert to be consistent). http://codereview.chromium.org/316010/diff/9002/6004#newcode932 Line 932: case 0xD8: mnem = "fstp"; break; Do we have a "fst" implementation? http://codereview.chromium.org/316010/diff/9002/6004#newcode1067 Line 1067: ASSERT((*current & 0xC0) != 0xC0); ASSERT_NE http://codereview.chromium.org/316010 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
