http://codereview.chromium.org/316010/diff/9002/6004 File src/x64/disasm-x64.cc (right):
http://codereview.chromium.org/316010/diff/9002/6004#newcode661 Line 661: assert(*data == 0xF7 || *data == 0xF6); On 2009/10/27 09:01:40, Lasse Reichstein wrote: > Shouldn't this be ASSERT? (I.e., using our own ASSERT, not the C++ assert.h > library). All asserts changed to ASSERT_EQ, ASSERT_NE, or ASSERT in both files. http://codereview.chromium.org/316010/diff/9002/6004#newcode932 Line 932: case 0xD8: mnem = "fstp"; break; On 2009/10/27 09:01:40, Lasse Reichstein wrote: > Do we have a "fst" implementation? That's a big "affirmative", partner. http://codereview.chromium.org/316010 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
