LGTM. The comment in simulator-arm.cc about the exit stub never moving worries me.
http://codereview.chromium.org/330017/diff/1/42 File src/arm/frames-arm.cc (right): http://codereview.chromium.org/330017/diff/1/42#newcode60 Line 60: if (is_debug_exit) Are we no longer insisting on {} for multi-line if statements? http://codereview.chromium.org/330017/diff/1/41 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/330017/diff/1/41#newcode300 Line 300: mov(ip, Operand(0)); This should be Smi::FromInt(0) http://codereview.chromium.org/330017/diff/1/18 File src/codegen.h (right): http://codereview.chromium.org/330017/diff/1/18#newcode342 Line 342: // The accessor info associated with the function Full stop. http://codereview.chromium.org/330017/diff/1/18#newcode344 Line 344: // The function to be called Period. http://codereview.chromium.org/330017/diff/1/11 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/330017/diff/1/11#newcode7910 Line 7910: ExitFrame::Mode mode = is_debug_break There's that single = again! http://codereview.chromium.org/330017/diff/1/12 File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/330017/diff/1/12#newcode957 Line 957: // Push the number of extensions, smi-tagged for make benefit the gc. This comment makes benefit the geekiness of the code, but it doesn't make benefit the readability. http://codereview.chromium.org/330017/diff/1/12#newcode961 Line 961: shl(scratch, kSmiTagSize); Here and below you are making use of the fact that the Smi tag is zero. You should assert that this is the case. http://codereview.chromium.org/330017/diff/1/15 File src/ia32/macro-assembler-ia32.h (right): http://codereview.chromium.org/330017/diff/1/15#newcode80 Line 80: // Enter specific kind of exit frame; either EXIT or Comment looks outdated. http://codereview.chromium.org/330017/diff/3011/3040 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/330017/diff/3011/3040#newcode1803 Line 1803: push(Immediate(0)); Smi::FromInt(0) http://codereview.chromium.org/330017 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
