http://codereview.chromium.org/330017/diff/1/19 File src/api.h (right):
http://codereview.chromium.org/330017/diff/1/19#newcode130 Line 130: enum Kind { GETTER }; I certainly hope that you have concrete plans to expand this enum, otherwise it smells of http://c2.com/cgi/wiki?PrematureGeneralization http://codereview.chromium.org/330017/diff/1/40 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/330017/diff/1/40#newcode5906 Line 5906: ExitFrame::Mode mode = is_debug_break This single = in a boolean context worries me. Perhaps a comment could soothe my frayed nervers. Or perhaps it's just wrong. http://codereview.chromium.org/330017 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
