On 2015/01/29 10:52:56, kozyatinskiy wrote:
Thanks!
https://codereview.chromium.org/879553002/diff/60001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/879553002/diff/60001/include/v8.h#newcode980
include/v8.h:980: Handle<Boolean> resource_is_debugger_script =
Handle<Boolean>())
On 2015/01/28 14:02:04, Yang wrote:
> Can we call this (and elsewhere) something more generic like
> resource_is_embedder_script?
Renamed to is_embedder_debug_script.
https://codereview.chromium.org/879553002/diff/60001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/879553002/diff/60001/src/accessors.cc#newcode794
src/accessors.cc:794: void Accessors::ScriptIsDebuggerScriptGetter(
On 2015/01/28 09:47:30, Yang wrote:
> Why is this necessary? I don't see it for the is_shared_cross_origin
flag.
We use this variable in our DebuggerScript.js in blink. We need to have
this
accessor for receiving script information after compile.
https://codereview.chromium.org/879553002/diff/60001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/879553002/diff/60001/src/api.cc#newcode1924
src/api.cc:1924: v8::Boolean::New(v8_isolate,
script->is_shared_cross_origin()),
On 2015/01/28 14:02:04, Yang wrote:
> This is great. I noticed that this is missing and would have cause a
lot of
head
> scratching. Can you add a check to check_message_3 in test-api.cc?
>
> CHECK(message->GetScriptOrigin().ResourceIsSharedCrossOrigin());
Done.
https://codereview.chromium.org/879553002/diff/60001/src/api.cc#newcode4096
src/api.cc:4096: v8::Integer::New(isolate,
script->column_offset()->value()));
On 2015/01/28 14:02:04, Yang wrote:
> Can we fix this place as well?
Done.
And checks added to test-api.cc
lgtm.
https://codereview.chromium.org/879553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
