We should rework this API, but this is not something for today, and I don't
want
to block your progress. I have some comments. And there need to be test
cases
for this (just add a couple of CHECKs to test-api.cc).
https://codereview.chromium.org/879553002/diff/60001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/879553002/diff/60001/include/v8.h#newcode980
include/v8.h:980: Handle<Boolean> resource_is_debugger_script =
Handle<Boolean>())
Can we call this (and elsewhere) something more generic like
resource_is_embedder_script?
https://codereview.chromium.org/879553002/diff/60001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/879553002/diff/60001/src/api.cc#newcode1924
src/api.cc:1924: v8::Boolean::New(v8_isolate,
script->is_shared_cross_origin()),
This is great. I noticed that this is missing and would have cause a lot
of head scratching. Can you add a check to check_message_3 in
test-api.cc?
CHECK(message->GetScriptOrigin().ResourceIsSharedCrossOrigin());
https://codereview.chromium.org/879553002/diff/60001/src/api.cc#newcode4096
src/api.cc:4096: v8::Integer::New(isolate,
script->column_offset()->value()));
Can we fix this place as well?
https://codereview.chromium.org/879553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
