On 2015/01/30 03:53:22, arv wrote:
This patch is getting pretty big. Could you split the parser into its own
CL.
That part is pretty non controversial and it might make it simpler to
track
down
the remaining issues.
I'll have that up tonight
https://codereview.chromium.org/816913003/diff/510001/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):
https://codereview.chromium.org/816913003/diff/510001/src/mips/code-stubs-mips.cc#newcode2015
src/mips/code-stubs-mips.cc:2015: void
RestParamAccessStub::GenerateNew(MacroAssembler* masm) {
You don't need to do mips. Only ia32, x64, arm and arm64. The rest are
optional
and gets ported by other people. They will of course be happy if you do
these.
The codegen stuff is all really baseline and basic (just wrappers for a
runtime
call) so they will probably find some work to make them better... I can
remove
the mips stuff if it makes it easier to review
https://codereview.chromium.org/816913003/diff/510001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/816913003/diff/510001/src/scopes.cc#newcode462
src/scopes.cc:462: DCHECK(rest_parameter_ == NULL);
DCHECK_EQ
Acknowledged
https://codereview.chromium.org/816913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
