It still fails the 5th stress-opt run (rest parameter is undefined rather
than
an array).
If you add --turbo-filter=* to the command line, it passes beautifully, so
it
seems like on the 5th run, instead of aborting compilation, it just keeps
going
and never assigns the rest parameter.
I've tried adding a simple crankshaft implementation just to make it pass
that,
but it doesn't seem to like adding new instructions at that point. It would
be
better if it can get around having no crankshaft implementation at all
https://codereview.chromium.org/816913003/diff/630001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/816913003/diff/630001/src/objects.h#newcode4338
src/objects.h:4338: class IsSimpleParameterListField : public
BitField<bool, 13, 1> {};
On 2015/02/12 21:48:43, arv wrote:
14 or AsmFunctionField::kNext
Oops, fixed! I'm going with the kNext option, seems less error-prone
https://codereview.chromium.org/816913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
