Looking good. Merging some of the very similar tests would be nice
though... I
presume it can be reduced by quite a few lines of testcode, which improves
future maintainability.
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc#newcode2415
src/objects.cc:2415: next_location = store_mode == FORCE_FIELD ? kField
: kDescriptor;
isn't this guaranteed above?
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc#newcode2466
src/objects.cc:2466: } else {
else if
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc#newcode2569
src/objects.cc:2569: PropertyKind merged_kind = target_details.kind();
I wouldn't call this merged_, since you aren't merging data; rather
choosing between the current or new_kind.
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc#newcode2591
src/objects.cc:2591: merged_attributes = new_attributes;
Same as above
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc#newcode2639
src/objects.cc:2639: PropertyAttributes merged_attributes =
old_details.attributes();
Same for all above
https://codereview.chromium.org/888623002/diff/20001/test/cctest/test-migrations.cc
File test/cctest/test-migrations.cc (right):
https://codereview.chromium.org/888623002/diff/20001/test/cctest/test-migrations.cc#newcode686
test/cctest/test-migrations.cc:686: }
Seems like you could merge the few tests above into a single one that
has arrays of [[start_repr, new_repr]*]. If you add "deprecated" you can
also handle none->* cases.
https://codereview.chromium.org/888623002/diff/20001/test/cctest/test-migrations.cc#newcode1122
test/cctest/test-migrations.cc:1122:
TEST(ReconfigureDataFieldAttribute_GeneralizeRepresentationSmiToDouble)
{
Same here?
https://codereview.chromium.org/888623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
