I addressed comments, refactored tests and added more of them.
I also slightly changed behavior in case of property kind reconfiguring (see
ReconfigureAccessorToNonExistingDataField* tests) which caused changes in
LookupIterator.
PTAL
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc#newcode2415
src/objects.cc:2415: next_location = store_mode == FORCE_FIELD ? kField
: kDescriptor;
On 2015/01/30 13:02:53, Toon Verwaest wrote:
isn't this guaranteed above?
Done.
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc#newcode2466
src/objects.cc:2466: } else {
On 2015/01/30 13:02:53, Toon Verwaest wrote:
else if
Done.
https://codereview.chromium.org/888623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
