Reviewers: ulan,
Message:
Hi Ulan,
Here is another run at the WeakCell work. The "new" work is in the 2nd
patchset.
I won't check this in until this CL has landed
(https://codereview.chromium.org/892113002/). The reason is that the change
to
use WeakCells for calls exposed a bug where confusion between slots and ic
slots
was tolerated.
Thanks again,
--Michael
Description:
Retry "Use a WeakCell in the CallIC type vector."
The first try failed because I needed to make a better distinction
between clearing ICs according to policy at GC time or unconditional
clearing (say, via %ClearFunctionTypeFeedback).
It was also blocked by an issue in super constructor calls.
This fix (https://codereview.chromium.org/892113002/) needs to land
before checking in this CL.
[email protected]
Please review this at https://codereview.chromium.org/866493003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+347, -102 lines):
M src/arm/code-stubs-arm.cc
M src/arm/interface-descriptors-arm.cc
M src/arm64/code-stubs-arm64.cc
M src/arm64/interface-descriptors-arm64.cc
M src/code-stubs.h
M src/code-stubs.cc
M src/code-stubs-hydrogen.cc
M src/heap/objects-visiting-inl.h
M src/hydrogen-instructions.h
M src/ia32/code-stubs-ia32.cc
M src/ia32/interface-descriptors-ia32.cc
M src/ic/ic.cc
M src/interface-descriptors.h
M src/objects.h
M src/objects.cc
M src/type-feedback-vector.h
M src/type-feedback-vector.cc
M src/type-info.cc
M src/x64/code-stubs-x64.cc
M src/x64/interface-descriptors-x64.cc
M test/cctest/test-compiler.cc
M test/cctest/test-feedback-vector.cc
M test/cctest/test-heap.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
