Reviewers: Benedikt Meurer,
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc
File src/compiler/move-optimizer.cc (right):
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode13
src/compiler/move-optimizer.cc:13: struct MoveKey {
On 2015/01/28 05:18:51, Benedikt Meurer wrote:
Once the issues mentioned below are addressed, how about getting rid
of this
struct and using std::pair<InstructionOperand, InstructionOperand>
instead?
Done.
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode18
src/compiler/move-optimizer.cc:18: struct OperandLess {
On 2015/01/28 05:18:51, Benedikt Meurer wrote:
Can you add an operator< (and operator>) to InstructionOperand
instead?
now that it's 64 bits, it might be a little wierd, since we only care
about kind and index... i can add them though if you want.
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode34
src/compiler/move-optimizer.cc:34: typedef std::set<InstructionOperand,
std::less<InstructionOperand>,
On 2015/01/28 05:18:51, Benedikt Meurer wrote:
I guess this shouldn't be std::less<InstructionOperand>, but rather
OperandLess?
Done.
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode36
src/compiler/move-optimizer.cc:36: typedef std::map<MoveKey, unsigned,
MoveKeyLess,
On 2015/01/28 05:18:51, Benedikt Meurer wrote:
How about adding ZoneSet and ZoneMap to zone-containers.h and getting
rid of
these typedefs, and replacing the classes below with simple typedefs?
Done.
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode141
src/compiler/move-optimizer.cc:141: static int
FindFirstNonEmptySlot(GapInstruction* gap) {
On 2015/01/28 05:18:51, Benedikt Meurer wrote:
Nit: use anonymous namespace instead of static.
Done.
Description:
[turbofan] optimize moves into merges
cleaned up the MoveOptimizer a bit along the way
BUG=
Please review this at https://codereview.chromium.org/755323011/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+195, -0 lines):
M src/compiler/move-optimizer.h
M src/compiler/move-optimizer.cc
M test/unittests/compiler/move-optimizer-unittest.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
