On 2015/02/02 17:08:42, Michael Starzinger wrote:
Had to re-iterate on one of your comments. PTAL.
https://codereview.chromium.org/873423004/diff/1/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/873423004/diff/1/src/compiler/ast-graph-builder.cc#newcode351
src/compiler/ast-graph-builder.cc:351: return
owner_->NewNode(owner_->javascript()->StrictEqual(), t1, t2);
On 2015/02/02 14:47:41, Michael Starzinger wrote:
> On 2015/02/02 09:47:29, titzer wrote:
> > I think you want pointer/integer equality here. JS operators are for
> expressing
> > source program computations, not internal computations.
>
> Done.
Yeah, well, ain't gonna happen as long as our Phi's have a machine
representation and are all marked as tagged. I left a TODO and verified,
we
correctly lower to Word32Equal in the pipeline, so the code at the end
should
be
"optimal" already.
Ok.
https://codereview.chromium.org/873423004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
