https://codereview.chromium.org/873423004/diff/60001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/873423004/diff/60001/src/compiler/ast-graph-builder.cc#newcode457
src/compiler/ast-graph-builder.cc:457: void
AstGraphBuilder::ControlScope::BreakTarget(BreakableStatement* stmt) {
The names {BreakTarget} and {ContinueTarget} have always been a little
confusing to me. Maybe {BreakTo} and {ContinueTo} would be clearer? Then
it would read:
execution_control()->ContinueTo(stmt->target())
https://codereview.chromium.org/873423004/diff/60001/src/compiler/ast-graph-builder.h
File src/compiler/ast-graph-builder.h (right):
https://codereview.chromium.org/873423004/diff/60001/src/compiler/ast-graph-builder.h#newcode456
src/compiler/ast-graph-builder.h:456: // Control scope implementation
for a BreakableStatement.
Is it necessary to put these full declarations in the header? If you
move them to the .cc file then they each can be fully self-contained.
https://codereview.chromium.org/873423004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
