LGTM with nits.
Just for the record, I am not crazy about using if (!x) ... for non-nullness
checks (because it tends to be brittle when you change x to a different
type).
https://codereview.chromium.org/899433005/diff/20001/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):
https://codereview.chromium.org/899433005/diff/20001/src/compiler/scheduler.cc#newcode1354
src/compiler/scheduler.cc:1354: BasicBlock* block =
marking_queue_.front();
Please, do not shadow the 'block' parameter.
https://codereview.chromium.org/899433005/diff/20001/src/compiler/scheduler.cc#newcode1388
src/compiler/scheduler.cc:1388: if (!use_node) {
Are you sure this is always initially zero?
https://codereview.chromium.org/899433005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
