Thanks, issues addressed.
https://codereview.chromium.org/899433005/diff/20001/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):
https://codereview.chromium.org/899433005/diff/20001/src/compiler/scheduler.cc#newcode1354
src/compiler/scheduler.cc:1354: BasicBlock* block =
marking_queue_.front();
On 2015/02/03 14:27:06, jarin wrote:
Please, do not shadow the 'block' parameter.
Done.
https://codereview.chromium.org/899433005/diff/20001/src/compiler/scheduler.cc#newcode1388
src/compiler/scheduler.cc:1388: if (!use_node) {
Yes, that's due to the definition of operator[].
https://codereview.chromium.org/899433005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
