Cute. Couple of comments need to be updated in each platform-specific backend file.
LGTM. http://codereview.chromium.org/342019/diff/1/4 File src/compiler.cc (right): http://codereview.chromium.org/342019/diff/1/4#newcode855 Line 855: Visit(expr->right()); Should have a comment wherever we intentionally call plain Visit in order to inherit the parent context. http://codereview.chromium.org/342019/diff/1/2 File src/fast-codegen.h (right): http://codereview.chromium.org/342019/diff/1/2#newcode81 Line 81: void LogicalOperation(BinaryOperation* expr); GenerateLogicalOperation? EmitLogicalOperation? http://codereview.chromium.org/342019/diff/1/3 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/342019/diff/1/3#newcode619 Line 619: // Compile a short-circuited boolean or operation in a non-test Update comment. http://codereview.chromium.org/342019/diff/1/3#newcode669 Line 669: // (let (temp = e0) temp ? temp : e1). Update comment. http://codereview.chromium.org/342019 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
