http://codereview.chromium.org/342019/diff/1/4 File src/compiler.cc (right):
http://codereview.chromium.org/342019/diff/1/4#newcode855 Line 855: Visit(expr->right()); On 2009/10/28 15:34:07, Kevin Millikin wrote: > Should have a comment wherever we intentionally call plain Visit in order to > inherit the parent context. Done. http://codereview.chromium.org/342019/diff/1/2 File src/fast-codegen.h (right): http://codereview.chromium.org/342019/diff/1/2#newcode81 Line 81: void LogicalOperation(BinaryOperation* expr); On 2009/10/28 15:34:07, Kevin Millikin wrote: > GenerateLogicalOperation? EmitLogicalOperation? Done. http://codereview.chromium.org/342019/diff/1/3 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/342019/diff/1/3#newcode619 Line 619: // Compile a short-circuited boolean or operation in a non-test On 2009/10/28 15:34:07, Kevin Millikin wrote: > Update comment. Done. http://codereview.chromium.org/342019/diff/1/3#newcode669 Line 669: // (let (temp = e0) temp ? temp : e1). On 2009/10/28 15:34:07, Kevin Millikin wrote: > Update comment. Done. http://codereview.chromium.org/342019 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
