lgtm
https://codereview.chromium.org/902093002/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/902093002/diff/1/src/compiler.cc#newcode1138
src/compiler.cc:1138: DCHECK(info->is_eval() || info->is_global() ||
info->is_module());
Yeah, this is starting to get me worried. Module code is not "toplevel",
so I'm wondering what assumptions might break with this. At some point
we'll probably have to rethink/refactor this.
https://codereview.chromium.org/902093002/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/902093002/diff/1/src/full-codegen.cc#newcode730
src/full-codegen.cc:730: // DeclareModules(modules_);
Is this stray? Or a TODO?
https://codereview.chromium.org/902093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
