https://codereview.chromium.org/902093002/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/902093002/diff/1/src/compiler.cc#newcode1138
src/compiler.cc:1138: DCHECK(info->is_eval() || info->is_global() ||
info->is_module());
On 2015/02/06 12:36:56, rossberg wrote:
Yeah, this is starting to get me worried. Module code is not
"toplevel", so I'm
wondering what assumptions might break with this. At some point we'll
probably
have to rethink/refactor this.
I wouldn't be too worried, yet anyway. This is why I wanted to get the
compiler working, so I can get some more tests in and then refactor as
need-be. In the mid-term run, I think we probably do want to make module
compilation more separate from toplevel compilation. But doing that
right now would lead either to too much code duplication or too much
brokenness.
If you have concrete suggestions for refactoring that could happen
earlier, please let me know.
https://codereview.chromium.org/902093002/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/902093002/diff/1/src/full-codegen.cc#newcode730
src/full-codegen.cc:730: // DeclareModules(modules_);
On 2015/02/06 12:36:56, rossberg wrote:
Is this stray? Or a TODO?
Oops. This is a TODO, I thought I'd managed to fix everything but I have
not yet. Added more explanation.
https://codereview.chromium.org/902093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
