http://codereview.chromium.org/342058/diff/1/5
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/342058/diff/1/5#newcode963
Line 963: case Expression::kTest:
On 2009/11/01 15:33:28, William Hesse wrote:
> Could all the test contexts be implemented by a simple
> pop(rax)
> Move(context, rax)?


The code would be simpler, at the cost of popping then pushing for the
two hybrid test contexts.

I'd leave it like this for now.  We'll clearly have to revisit value
contexts and break them out by where the value already is (or where it
wants to be).

http://codereview.chromium.org/342058

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to