LGTM.
http://codereview.chromium.org/342058/diff/1/4 File src/compiler.cc (right): http://codereview.chromium.org/342058/diff/1/4#newcode844 Line 844: if (expr->is_prefix()) BAILOUT("Prefix CountOperation"); Putting an assert that expr->is_postfix in the platform-specific implementations of code generation would make it easier to read them, and check them, correctly. http://codereview.chromium.org/342058/diff/1/5 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/342058/diff/1/5#newcode963 Line 963: case Expression::kTest: Could all the test contexts be implemented by a simple pop(rax) Move(context, rax)? http://codereview.chromium.org/342058 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
