I like getting rid of the isolate in the parser.
As discussed in person, there will be some conflict with splitting up
CompilationInfo into a separate ParserInfo. The idea there being that the
ParseInfo data structure contains both the inputs to parsing and the output
of
parsing (potentially include errors), and nothing more. Then some of the
instance fields of Parser and Preparser can be factored out into that
ParseInfo.
WDYT?
https://codereview.chromium.org/908173003/diff/40001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/908173003/diff/40001/src/parser.h#newcode670
src/parser.h:670: bool Parse(CompilationInfo* info);
What about renaming this ParseSynchronous() and then keeping the name
for the other?
https://codereview.chromium.org/908173003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
