thx for review.
The naming is not that great still, but idk... ParseSynchronous doesn't
transmit
the meaning either, since ParseOnBackground is also synchronous (it doesn't
launch a background task or anything, it's just a func meant to be called
on a
background thread).
https://codereview.chromium.org/908173003/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/908173003/diff/1/src/parser.cc#newcode917
src/parser.cc:917: // created. This kind of parsing can only be done in
the main thread.
On 2015/02/12 10:31:29, rossberg wrote:
Is there a way to DCHECK that here?
I added a bool parsing_on_main_thread_ which ParseOnBackground sets to
false and which can then be checked.
https://codereview.chromium.org/908173003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
