PTAL
https://codereview.chromium.org/934463003/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/934463003/diff/20001/src/objects.cc#newcode3148
src/objects.cc:3148: if (data_store_mode == SUPER_PROPERTY) {
To me it looks like this if can be skipped since this code path is not
specific to super properties, it is just very hard to get here without
super (you would have to use a proxy).
https://codereview.chromium.org/934463003/diff/20001/src/objects.cc#newcode3151
src/objects.cc:3151: if (!own_lookup.IsFound()) {
Is there an existing function that can be used here? I feel dirty doing
all this logic here.
https://codereview.chromium.org/934463003/diff/20001/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/934463003/diff/20001/test/mjsunit/harmony/super.js#newcode1413
test/mjsunit/harmony/super.js:1413: // TODO(arv): This is broken
The runtime calls SetElementWithInterceptor. It does not do the
DefineOwnProperty on the instance. SetElementWithInterceptor only has
one user, namely StoreElementToSuper in runtime-classes.cc.
https://codereview.chromium.org/934463003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
