This is looking good to me, but I definitely think that Toon should take a
look
at this. In particular, that big if clause is getting ugly, and the switch
to
passing DEFINE_PROPERTY in from SetElementWithReceiver seems like a
signficant
structural change.
https://codereview.chromium.org/934463003/diff/100001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/934463003/diff/100001/src/objects.cc#newcode3174
src/objects.cc:3174: NewTypeError("redefine_disallowed",
On 2015/02/18 01:00:04, arv wrote:
Maybe I should just use strict_read_only_property here as well?
Or just make a new RedefineNonconfigurableProperty() method and factor
the logic out into that?
https://codereview.chromium.org/934463003/diff/100001/src/objects.cc#newcode12880
src/objects.cc:12880: details.IsReadOnly() && details.kind() == kData)
||
I take it we don't need this !IsTheHole() check in the DEFINE_PROPERTY
case simply because we don't exercise that code path?
https://codereview.chromium.org/934463003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
