LGTM if comments are addressed.
https://codereview.chromium.org/934293002/diff/1/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/934293002/diff/1/src/compiler/ast-graph-builder.cc#newcode441
src/compiler/ast-graph-builder.cc:441: if (constant_context) {
nit: Can we move this logic into GetFunctionContext, pass in the boolean
and just call it from here?
https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer.cc
File src/compiler/control-reducer.cc (right):
https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer.cc#newcode301
src/compiler/control-reducer.cc:301: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
Please use the "FATAL" macro here instead of inlining this.
https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer.cc#newcode307
src/compiler/control-reducer.cc:307: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
Please use the "FATAL" macro here instead of inlining this.
https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc
File src/compiler/verifier.cc (right):
https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#newcode73
src/compiler/verifier.cc:73: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
Please use the "FATAL" macro here instead of inlining this.
https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#newcode84
src/compiler/verifier.cc:84: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
Likewise.
https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#newcode95
src/compiler/verifier.cc:95: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
Likewise.
https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#newcode108
src/compiler/verifier.cc:108: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
Likewise.
https://codereview.chromium.org/934293002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
