https://codereview.chromium.org/934293002/diff/1/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/934293002/diff/1/src/compiler/ast-graph-builder.cc#newcode441
src/compiler/ast-graph-builder.cc:441: if (constant_context) {
On 2015/02/18 17:37:32, Michael Starzinger wrote:
nit: Can we move this logic into GetFunctionContext, pass in the
boolean and
just call it from here?
As discussed in person, I've moved this into CreateFunctionContext and
inlined the function_context_.get() at usage sites.
https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer.cc
File src/compiler/control-reducer.cc (right):
https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer.cc#newcode301
src/compiler/control-reducer.cc:301: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
On 2015/02/18 17:37:32, Michael Starzinger wrote:
Please use the "FATAL" macro here instead of inlining this.
Done (here and below).
https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc
File src/compiler/verifier.cc (right):
https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#newcode73
src/compiler/verifier.cc:73: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
On 2015/02/18 17:37:33, Michael Starzinger wrote:
Please use the "FATAL" macro here instead of inlining this.
Done (here and below).
https://codereview.chromium.org/934293002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
