General direction is good.
One question that bugs me: Why don't we embed the handler table into the
code
object?
https://codereview.chromium.org/943503003/diff/1/src/compiler/code-generator.cc
File src/compiler/code-generator.cc (right):
https://codereview.chromium.org/943503003/diff/1/src/compiler/code-generator.cc#newcode136
src/compiler/code-generator.cc:136: if (handlers_.size() > 0) {
if (!handlers_.empty())
https://codereview.chromium.org/943503003/diff/1/src/compiler/code-generator.h
File src/compiler/code-generator.h (right):
https://codereview.chromium.org/943503003/diff/1/src/compiler/code-generator.h#newcode30
src/compiler/code-generator.h:30: struct HandlerInfo {
I think this should be a private member of CodeGenerator.
https://codereview.chromium.org/943503003/diff/1/src/compiler/ia32/instruction-selector-ia32.cc
File src/compiler/ia32/instruction-selector-ia32.cc (right):
https://codereview.chromium.org/943503003/diff/1/src/compiler/ia32/instruction-selector-ia32.cc#newcode749
src/compiler/ia32/instruction-selector-ia32.cc:749:
CallDescriptor::Flags flags;
how about initializing flags to descriptor->flags() here, and skipping
the ORing below?
https://codereview.chromium.org/943503003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/943503003/diff/1/src/objects.cc#newcode11724
src/objects.cc:11724: os << buf.start();
How about using ios formatting here instead of SNPrintF and temp vector?
https://codereview.chromium.org/943503003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
