LGTM
https://codereview.chromium.org/939303002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/939303002/diff/1/src/parser.cc#newcode648
src/parser.cc:648: parser_->pending_error_is_reference_error_ =
error_type == kReferenceError;
Maybe change pending_error_is_reference_error_ to pending_error_type_?
https://codereview.chromium.org/939303002/diff/1/src/preparse-data.cc
File src/preparse-data.cc (right):
https://codereview.chromium.org/939303002/diff/1/src/preparse-data.cc#newcode45
src/preparse-data.cc:45: function_store_.Add(error_type ==
kReferenceError ? 1 : 0);
Can you just Add(error_type) here?
https://codereview.chromium.org/939303002/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/939303002/diff/1/src/preparser.h#newcode2987
src/preparser.h:2987: "unexpected_token", "ILLEGAL", kSyntaxError);
Maybe remove kSyntaxError here and other places since that is the
default?
https://codereview.chromium.org/939303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
