https://codereview.chromium.org/939303002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/939303002/diff/1/src/parser.cc#newcode648
src/parser.cc:648: parser_->pending_error_is_reference_error_ =
error_type == kReferenceError;
On 2015/02/19 21:41:59, arv wrote:
Maybe change pending_error_is_reference_error_ to pending_error_type_?
Done.
https://codereview.chromium.org/939303002/diff/1/src/preparse-data.cc
File src/preparse-data.cc (right):
https://codereview.chromium.org/939303002/diff/1/src/preparse-data.cc#newcode45
src/preparse-data.cc:45: function_store_.Add(error_type ==
kReferenceError ? 1 : 0);
On 2015/02/19 21:41:59, arv wrote:
Can you just Add(error_type) here?
I'd rather not depend on the numeric value of the enum in a
serialization.
On another topic, it looks like this serialized data is only used by
tests?
https://codereview.chromium.org/939303002/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/939303002/diff/1/src/preparser.h#newcode2987
src/preparser.h:2987: "unexpected_token", "ILLEGAL", kSyntaxError);
On 2015/02/19 21:41:59, arv wrote:
Maybe remove kSyntaxError here and other places since that is the
default?
I'd like to leave that for a followup. With all the overloads right now
it's possible these arguments are there to avoid ambiguity.
https://codereview.chromium.org/939303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
