https://codereview.chromium.org/929733003/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/929733003/diff/20001/src/parser.cc#newcode2955
src/parser.cc:2955: NULL,
Runtime::FunctionForId(Runtime::kInlineIsSpecObject),
I think you need to pass a non-NULL AstRawString here, otherwise
Crankshaft will crash in a DCHECK:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/hydrogen.cc&l=9953
Looks like we already do this for %_IsConstructCall()
(is_construct_call_string is in ast-value-factory.h).
https://codereview.chromium.org/929733003/diff/20001/src/parser.cc#newcode2964
src/parser.cc:2964: NULL,
Ditto, you should pass a real name here.
https://codereview.chromium.org/929733003/diff/20001/src/runtime/runtime-generator.cc
File src/runtime/runtime-generator.cc (right):
https://codereview.chromium.org/929733003/diff/20001/src/runtime/runtime-generator.cc#newcode228
src/runtime/runtime-generator.cc:228:
RUNTIME_FUNCTION(Runtime_ThrowIteratorResultNotAnObject) {
Can you put this up before the two RuntimeReference functions?
https://codereview.chromium.org/929733003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
