Thanks
https://codereview.chromium.org/929733003/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/929733003/diff/20001/src/parser.cc#newcode2964
src/parser.cc:2964: NULL,
On 2015/02/23 22:35:35, adamk wrote:
On 2015/02/23 22:26:09, arv wrote:
> On 2015/02/23 22:17:10, adamk wrote:
> > Ditto, you should pass a real name here.
>
> I added the strings but I ran this in debug mode without hitting the
assert.
>
> Probably because Crankshaft does not support for-of.
Hmm, ok, looks like empty_string is used in some other places, so I
guess this
is fine. I'm not sure I see the downside to giving these things proper
names,
though.
I added the strings.
https://codereview.chromium.org/929733003/diff/20001/src/runtime/runtime-generator.cc
File src/runtime/runtime-generator.cc (right):
https://codereview.chromium.org/929733003/diff/20001/src/runtime/runtime-generator.cc#newcode228
src/runtime/runtime-generator.cc:228:
RUNTIME_FUNCTION(Runtime_ThrowIteratorResultNotAnObject) {
On 2015/02/23 22:35:35, adamk wrote:
On 2015/02/23 22:26:09, arv wrote:
> On 2015/02/23 22:17:11, adamk wrote:
> > Can you put this up before the two RuntimeReference functions?
>
> That is clearly better.
>
> My q was more about which file. for-of is not tied to generators so
maybe
this
> should go somewhere else?
I think the set of runtime-foo.cc files is pretty arbitrary. You could
just
create a new runtime-iterators.cc file.
Moved to runtime-internal.cc which has ThrowReferenceError.
https://codereview.chromium.org/929733003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
