https://codereview.chromium.org/943543002/diff/320001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/943543002/diff/320001/src/parser.cc#newcode1820
src/parser.cc:1820: name, mode, declaration->initialization(),
declaration->position(),
Hm, I'm confused, why is this the right init position?
https://codereview.chromium.org/943543002/diff/320001/src/parser.cc#newcode2039
src/parser.cc:2039: proxy->var()->set_initializer_position(pos);
I'm surprised that this isn't a problem, since 'pos' doesn't seem to
point at the right position.
https://codereview.chromium.org/943543002/diff/320001/test/mjsunit/strong/declaration-after-use.js
File test/mjsunit/strong/declaration-after-use.js (right):
https://codereview.chromium.org/943543002/diff/320001/test/mjsunit/strong/declaration-after-use.js#newcode68
test/mjsunit/strong/declaration-after-use.js:68: "'use strong'; if
(false) { for (let x = x; ; ) { } }",
Perhaps add
for (let x = y, y; ;) {}
https://codereview.chromium.org/943543002/diff/320001/test/mjsunit/strong/declaration-after-use.js#newcode77
test/mjsunit/strong/declaration-after-use.js:77:
assertThrowsHelper("'use strong'; if (false) { class C extends C { } }",
Also add versions for class expressions:
let C = class C2 extends C2 {}
let C = class extends C {}
Also, with --harmony-computed-property-names, the following ones become
relevant:
class C { [C]() {} }
class C { get [C]() {} }
class C { set [C]() {} }
class C { static [C]() {} }
https://codereview.chromium.org/943543002/diff/320001/test/mjsunit/strong/declaration-after-use.js#newcode98
test/mjsunit/strong/declaration-after-use.js:98: for (let var4a = 0,
var4b = 0; var4a + var4b < 4; var4a++, var4b++) {
Change to
var4b = var4a
https://codereview.chromium.org/943543002/diff/320001/test/mjsunit/strong/declaration-after-use.js#newcode142
test/mjsunit/strong/declaration-after-use.js:142: class C {
constructor() { C; } };
Add a
new C
after.
https://codereview.chromium.org/943543002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
