LGTM
My comments can be resolved after this CL lands if you prefer.
https://codereview.chromium.org/943543002/diff/420001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/943543002/diff/420001/src/parser.cc#newcode2240
src/parser.cc:2240: DCHECK(var != nullptr);
DCHECK_NOT_NULL
https://codereview.chromium.org/943543002/diff/420001/src/parser.cc#newcode2298
src/parser.cc:2298: // Record the end position of the initializer.
Maybe move this comment to before the if since it is same for both
branches.
https://codereview.chromium.org/943543002/diff/420001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/943543002/diff/420001/src/scopes.cc#newcode1081
src/scopes.cc:1081: // ones. TODO(marja,rossberg): Detect errors across
different evals
Move TODO to new line?
https://codereview.chromium.org/943543002/diff/420001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/943543002/diff/420001/src/scopes.h#newcode134
src/scopes.h:134: InitializationFlag init_flag, bool is_function,
Maybe use Variable::Kind here instead of the boolean?
https://codereview.chromium.org/943543002/diff/420001/test/mjsunit/strong/declaration-after-use.js
File test/mjsunit/strong/declaration-after-use.js (right):
https://codereview.chromium.org/943543002/diff/420001/test/mjsunit/strong/declaration-after-use.js#newcode82
test/mjsunit/strong/declaration-after-use.js:82: })();
Maybe test for-of loops too?
https://codereview.chromium.org/943543002/diff/420001/test/mjsunit/strong/declaration-after-use.js#newcode100
test/mjsunit/strong/declaration-after-use.js:100: "'use strong'; if
(false) { let C = class C2 { method() { C; } } }",
This is kind of weird.
What about?
let f = function g() {
g; // Error or not?
};
https://codereview.chromium.org/943543002/diff/420001/test/mjsunit/strong/declaration-after-use.js#newcode104
test/mjsunit/strong/declaration-after-use.js:104: // tests.
I'm surprised that doesn't work already?
https://codereview.chromium.org/943543002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
