Reviewers: jochen (slow), tandrii(chromium), Jakob,
Message:
PTAL
Description:
Clobber output directory on linux and mac after landmine.
Xcode uses a different naming scheme for directories within
the xcodebuild directory. But it is save to just delete
everything withing xcodebuild or out. Keep the soft clobber
for windows' build directory only, where subdirectories
follow the *release* and *debug* naming scheme.
BUG=chromium:403263
LOG=n
Please review this at https://codereview.chromium.org/955953002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+12, -5 lines):
M build/landmines.py
Index: build/landmines.py
diff --git a/build/landmines.py b/build/landmines.py
index
c41f123051a3829f65670c1d1be35f5df5dfafdc..d855315ee9e52826b62dd17ed9dd2b2a52a1516c
100755
--- a/build/landmines.py
+++ b/build/landmines.py
@@ -165,11 +165,18 @@ def clobber_if_necessary(new_landmines):
# checkouts have the build directory mounted.
for f in os.listdir(out_dir):
path = os.path.join(out_dir, f)
- # Soft version of chromium's clobber. Only delete directories not
files
- # as e.g. on windows the output dir is the build dir that shares some
- # checked out files.
- if os.path.isdir(path) and re.search(r"(?:[Rr]elease)|(?:[Dd]ebug)",
f):
- delete_build_dir(path)
+ if os.path.basename(out_dir) == 'build':
+ # Soft version of chromium's clobber. Only delete build
directories not
+ # files in windows' build dir as the folder shares some checked out
+ # files and directories.
+ if (os.path.isdir(path) and
+ re.search(r'(?:[Rr]elease)|(?:[Dd]ebug)', f)):
+ delete_build_dir(path)
+ else:
+ if os.path.isfile(path):
+ os.unlink(path)
+ elif os.path.isdir(path):
+ delete_build_dir(path)
# Save current set of landmines for next time.
with open(landmines_path, 'w') as f:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
