This factoring looks ok to me.
Implement for derived constructors first and then proceed from there.
https://codereview.chromium.org/949763003/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/949763003/diff/1/src/full-codegen.cc#newcode846
src/full-codegen.cc:846: // to execute the constructor and only fail
when an assignment to 'this'
I believe we can now kill this entire function and all its uses (since
now the parser guarantees that 'super(...)' only occurs where new.target
is avaliable.
https://codereview.chromium.org/949763003/diff/1/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/949763003/diff/1/src/scopes.cc#newcode315
src/scopes.cc:315: new_target_ =
I'd prefer not declaring new.target if it is not needed.
https://codereview.chromium.org/949763003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
