https://codereview.chromium.org/960343002/diff/120001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/960343002/diff/120001/src/accessors.cc#newcode1151
src/accessors.cc:1151: }
On 2015/02/26 23:31:51, adamk wrote:
You're going to want an EnqueueChangeRecord call here similar to the
one for
SetFunctionPrototype.
Unlike Function::SetPrototype, SetDataProperty already does this. You
might want to add a test though.
https://codereview.chromium.org/960343002/diff/120001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/960343002/diff/120001/src/lookup.cc#newcode316
src/lookup.cc:316: DCHECK(DATA == state_ || ACCESSOR == state_);
On 2015/02/26 22:30:37, arv wrote:
Toon, this cannot be right.
What is the right way to replace an accessor with a data property?
This isn't right indeed. Are you sure you need this?
it.PrepareForDataProperty() should have reconfigured and reloaded the
propertyinfo, so you should be in state_ == DATA by the time you
SetDataProperty.
https://codereview.chromium.org/960343002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
