https://codereview.chromium.org/960343002/diff/160001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/960343002/diff/160001/src/accessors.cc#newcode1147
src/accessors.cc:1147: value = it.WriteDataValue(value);
Turns out that I could not use SetDataProperty since it does not know
how to get the old value.

https://codereview.chromium.org/960343002/diff/160001/test/mjsunit/es7/object-observe.js
File test/mjsunit/es7/object-observe.js (right):

https://codereview.chromium.org/960343002/diff/160001/test/mjsunit/es7/object-observe.js#newcode1001
test/mjsunit/es7/object-observe.js:1001:
assertTrue(Object.getOwnPropertyDescriptor(obj, prop).configurable);
This happens in the stress test. Not sure why yet. Still investigating.

https://codereview.chromium.org/960343002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to