Lgtm
http://codereview.chromium.org/390020/diff/3007/3011 File src/objects-inl.h (right): http://codereview.chromium.org/390020/diff/3007/3011#newcode2997 Line 2997: // TODO(yurys): this may be useful in other places too where JSGlobalProxy TODOs should be of the form TODO(<issue number>) where the issue number corresponds to an issue describing the TODO. http://codereview.chromium.org/390020/diff/3007/3011#newcode2999 Line 2999: Object* JSObject::GetHiddenPropertiesObjectHolder() { As you say in the comment, this is actually a pretty general function. How about giving it a more descriptive name maybe, off the top of my head, BypassGlobalProxy. http://codereview.chromium.org/390020/diff/3007/3011#newcode3013 Line 3013: this, Heap::hidden_symbol(), false) != ABSENT; One argument per line. http://codereview.chromium.org/390020/diff/3007/3010 File src/objects.h (right): http://codereview.chromium.org/390020/diff/3007/3010#newcode1437 Line 1437: // Instead they are stored on an auxiliary Object stored as a local That should be "auxiliary JSObject" right? http://codereview.chromium.org/390020 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
