http://codereview.chromium.org/390020/diff/3007/3011 File src/objects-inl.h (right):
http://codereview.chromium.org/390020/diff/3007/3011#newcode2997 Line 2997: // TODO(yurys): this may be useful in other places too where JSGlobalProxy On 2009/11/12 15:30:00, Christian Plesner Hansen wrote: > TODOs should be of the form TODO(<issue number>) where the issue number > corresponds to an issue describing the TODO. Done. http://codereview.chromium.org/390020/diff/3007/3011#newcode2999 Line 2999: Object* JSObject::GetHiddenPropertiesObjectHolder() { On 2009/11/12 15:30:00, Christian Plesner Hansen wrote: > As you say in the comment, this is actually a pretty general function. How > about giving it a more descriptive name maybe, off the top of my head, > BypassGlobalProxy. Done. http://codereview.chromium.org/390020/diff/3007/3011#newcode3013 Line 3013: this, Heap::hidden_symbol(), false) != ABSENT; On 2009/11/12 15:30:00, Christian Plesner Hansen wrote: > One argument per line. Done. http://codereview.chromium.org/390020 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
