On 2015/03/06 06:38:43, loislo wrote:
On 2015/03/05 15:05:48, Sven Panne wrote:
> Good point, I didn't see that..
>
>
https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-profiler.cc
> File test/cctest/test-cpu-profiler.cc (right):
>
>
https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-profiler.cc#newcode1141
> test/cctest/test-cpu-profiler.cc:1141: delete processor;
> On 2015/03/05 14:57:40, yurys wrote:
> > Why not use SmartPointer?
>
> Or even simpler: Just avoid pointers altogether here and simply
construct
the
> object directly without new?
I don't know the exact reason but test is failing on OpenHandle when I
construct
the processor on the stack.
Putting it into a scope also doesn't work. So I used SmartPointer.
CollectDeoptEvents is failing on arm64 due to a problem in GetDeoptInfo.
bailout_id doesn't match with id from Deoptimizer::GetDeoptimizationId
I'll fix this in another patch.
https://codereview.chromium.org/976203003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
