On 2015/03/06 06:38:43, loislo wrote:
On 2015/03/05 15:05:48, Sven Panne wrote:
> Or even simpler: Just avoid pointers altogether here and simply
construct
the
> object directly without new?
I don't know the exact reason but test is failing on OpenHandle when I
construct
the processor on the stack.
Putting it into a scope also doesn't work. So I used SmartPointer.
I had a quick look: ProfilerEventsProcessor directly embeds a 1MB
SamplingCircularQueue, so stack-allocating a ProfilerEventsProcessor
probably
doesn't work on most platforms/compilers. Hmmm, this is quite unintuitive
and
not very nice... How about dynamically allocating the SamplingCircularQueue
and
keep only a (smart) pointer to it in the ProfilerEventsProcessor? This way,
the
processor could easily be stack-allocated.
https://codereview.chromium.org/976203003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
