https://codereview.chromium.org/919653002/diff/60001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/919653002/diff/60001/src/messages.js#newcode837
src/messages.js:837: if (IS_STRING(name)) {
On 2015/03/06 11:11:26, yurys wrote:
Is it supposed to return in case of empty string?
If user set empty function name then we show this like anonymous
function. I suppose it's correct behavior.
https://codereview.chromium.org/919653002/diff/60001/test/mjsunit/stack-traces.js
File test/mjsunit/stack-traces.js (right):
https://codereview.chromium.org/919653002/diff/60001/test/mjsunit/stack-traces.js#newcode108
test/mjsunit/stack-traces.js:108: Object.defineProperty(f, 'name',
{writable: true});
On 2015/03/06 11:11:26, yurys wrote:
Can you also test the case when value is passed as a configuration
option?
Done.
https://codereview.chromium.org/919653002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
