Yang, ptal.
https://codereview.chromium.org/919653002/diff/80001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/919653002/diff/80001/src/messages.js#newcode836
src/messages.js:836: var name = %GetDataProperty(fun, 'name');
On 2015/03/10 10:48:55, Yang wrote:
How about we make this part of %FunctionGetDebugName as well? So that
we have
one single place where we decide on what function name to display, not
two
places that act as fallback to each other.
Moved to JSFunction::DebugName.
https://codereview.chromium.org/919653002/diff/80001/test/mjsunit/stack-traces.js
File test/mjsunit/stack-traces.js (right):
https://codereview.chromium.org/919653002/diff/80001/test/mjsunit/stack-traces.js#newcode289
test/mjsunit/stack-traces.js:289: [" at foo_0 ", " at foo_1", " at foo
", " at boo_3 ", " at foo "]);
On 2015/03/10 10:48:55, Yang wrote:
Do we test the inferred name code path? I thought the inferred name in
this case
would be "f". You would of course have to assign an anonymous function
to it in
order to not use shared->name().
Test added.
https://codereview.chromium.org/919653002/diff/120001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/919653002/diff/120001/src/objects.cc#newcode10258
src/objects.cc:10258: HandleScope scope(GetIsolate());
Without this handle scope some tests fails with
# Fatal error in v8::HandleScope::CreateHandle()
# Cannot create a handle without a HandleScope
It seems strange for me, because we can't call this function without
outer scope in messages.js or CaptureStackTraceHelper.
Yang, please take a look on this line.
https://codereview.chromium.org/919653002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
