https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc#newcode124
src/lookup.cc:124: DCHECK(state_ !=
LookupIterator::INTEGER_INDEXED_EXOTIC);
DCHECK_NE
https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc#newcode337
src/lookup.cc:337: DCHECK(exotic_index_state_ !=
ExoticIndexState::kNoIndex);
DCHECK_NE
https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc#newcode340
src/lookup.cc:340: DCHECK(exotic_index_state_ ==
ExoticIndexState::kUninitialized);
DCHECK_EQ
https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc#newcode354
src/lookup.cc:354: AllowHeapAllocation allow;
Arg, reallowing allocation is crazy... that's going to cause bugs.
Just write a local integer parser instead. The current impl even seems
wrong. E.g., "2e+60" is handled as IntegerIndexedExotic, while I presume
it shouldn't be.
https://codereview.chromium.org/992913002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
