Reviewers: Toon Verwaest,
Message:
ptal
https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc#newcode124
src/lookup.cc:124: DCHECK(state_ !=
LookupIterator::INTEGER_INDEXED_EXOTIC);
On 2015/03/10 12:01:25, Toon Verwaest wrote:
DCHECK_NE
Done.
https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc#newcode337
src/lookup.cc:337: DCHECK(exotic_index_state_ !=
ExoticIndexState::kNoIndex);
On 2015/03/10 12:01:25, Toon Verwaest wrote:
DCHECK_NE
dcheck not okay with this
https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc#newcode340
src/lookup.cc:340: DCHECK(exotic_index_state_ ==
ExoticIndexState::kUninitialized);
On 2015/03/10 12:01:25, Toon Verwaest wrote:
DCHECK_EQ
same
https://codereview.chromium.org/992913002/diff/60001/src/lookup.cc#newcode354
src/lookup.cc:354: AllowHeapAllocation allow;
On 2015/03/10 12:01:25, Toon Verwaest wrote:
Arg, reallowing allocation is crazy... that's going to cause bugs.
Just write a local integer parser instead. The current impl even seems
wrong.
E.g., "2e+60" is handled as IntegerIndexedExotic, while I presume it
shouldn't
be.
Done.
Description:
handle the special snowflakes that are Integer Indexed Exotic objects
BUG=
Please review this at https://codereview.chromium.org/992913002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+209, -28 lines):
M src/conversions.h
M src/conversions.cc
M src/hydrogen.cc
M src/ic/handler-compiler.cc
M src/ic/ic.cc
M src/lookup.h
M src/lookup.cc
M src/lookup-inl.h
M src/objects.cc
M src/runtime/runtime-debug.cc
M test/cctest/test-conversions.cc
A test/mjsunit/es6/indexed-integer-exotics.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
