lgtm with some nits
https://codereview.chromium.org/992913002/diff/120001/src/conversions.cc
File src/conversions.cc (right):
https://codereview.chromium.org/992913002/diff/120001/src/conversions.cc#newcode525
src/conversions.cc:525: return offset == 2 && offset == to; // Match
just '-0'.
Quite some boilerplate pretending to be in a loop while you're not ...
return to == 2; without ++offset?
https://codereview.chromium.org/992913002/diff/120001/src/conversions.cc#newcode527
src/conversions.cc:527: uint64_t acc = 0;
Wrap the entire "fast-path" into
if (!negative) {....}}
And use the case below
while (offset != length) {...}
for negative values. That's probably faster given that you don't need to
keep track of the value, you'll always return "true" for
all-decimal-digit negative values, just like for
guaranteed-out-of-32bit-range positive values.
https://codereview.chromium.org/992913002/diff/120001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/992913002/diff/120001/src/lookup.cc#newcode124
src/lookup.cc:124: DCHECK_NE(state_,
LookupIterator::INTEGER_INDEXED_EXOTIC);
expected value on the left ... :)
https://codereview.chromium.org/992913002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
