lgtm with comments assuming it works :)
https://codereview.chromium.org/993173003/diff/20001/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/993173003/diff/20001/BUILD.gn#newcode22
BUILD.gn:22: # TODO(GYP): We should be just target_cpu and not need
v8_target_arch.
On 2015/03/11 at 13:47:48, Nico (traveling) wrote:
this reads grammared incorrectly
also, we want to be able to e.g. compile for linux x64 as target_cpu but
use v8_target_arch arm64. This will run v8 with a simulator, allowing
for better asan coverage.
https://codereview.chromium.org/993173003/diff/20001/BUILD.gn#newcode32
BUILD.gn:32: if (target_os == "android" || target_os == "chromeos") {
why this restriction?
https://codereview.chromium.org/993173003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
