https://codereview.chromium.org/993173003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/993173003/diff/20001/BUILD.gn#newcode22
BUILD.gn:22: # TODO(GYP): We should be just target_cpu and not need
v8_target_arch.
On 2015/03/11 16:10:30, jochen (slow) wrote:
On 2015/03/11 at 13:47:48, Nico (traveling) wrote:
> this reads grammared incorrectly

Will fix :).

also, we want to be able to e.g. compile for linux x64 as target_cpu
but use
v8_target_arch arm64. This will run v8 with a simulator, allowing for
better
asan coverage.

Sure.

https://codereview.chromium.org/993173003/diff/20001/BUILD.gn#newcode32
BUILD.gn:32: if (target_os == "android" || target_os == "chromeos") {
On 2015/03/11 16:10:30, jochen (slow) wrote:
why this restriction?

I'm not sure I understand the question. Which restriction are you
referring to?  The host must be linux restriction is there mostly to be
sure we understand what configurations are actually being called (i.e.,
I don't expect trying to build android v8 from windows to work at this
point, so I don't want people to try it and spend time debugging weird
things).

I'm happy to restructure it if you like.

https://codereview.chromium.org/993173003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to